slachiewicz / caliper

Automatically exported from code.google.com/p/caliper
Apache License 2.0
0 stars 0 forks source link

defualt parameters from static method or fields not implemented #234

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
The code in Param.java claims that two of the possible sources of default 
values are a static method or a static filed named xxxxValues. However, the 
code in Parameter.java doesn't implement this.

Either it should be implemented, or the documentation in Param.java changed.

Original issue reported on code.google.com by mzero@google.com on 5 Apr 2013 at 8:14

GoogleCodeExporter commented 9 years ago
Agreed.  Thanks for the report.

Original comment by gak@google.com on 11 Apr 2013 at 11:18

GoogleCodeExporter commented 9 years ago
Please confirm our fix is to fix the documentation :-)

(It was a misfeature.)

Original comment by kevinb@google.com on 13 Apr 2013 at 6:51

GoogleCodeExporter commented 9 years ago
The feature sounds cool... but it turns out I didn't need it for my case... and 
on reflection, since values need to be able to be parsed from string command 
line arguments, there really isn't any downside to specifying them as strings 
in the @Param decoration.

So yeah, fix should be to correct the documentation!

Original comment by mzero@google.com on 15 Apr 2013 at 4:24

GoogleCodeExporter commented 9 years ago
Confirmed.

Original comment by gak@google.com on 15 Apr 2013 at 5:22

GoogleCodeExporter commented 9 years ago

Original comment by gak@google.com on 24 Apr 2013 at 12:21