slack-go / slack

Slack API in Go, originally by @nlopes; Maintainers needed, contact @parsley42
https://pkg.go.dev/github.com/slack-go/slack
BSD 2-Clause "Simplified" License
4.65k stars 1.13k forks source link

Overlapping file types between slack and slackevents #1053

Open abustany opened 2 years ago

abustany commented 2 years ago

What's the rationale behind having two slightly different file types, one in the root package and one in slackevents? Would a PR to merge them have a chance to be accepted?

ArcticSnowman commented 1 year ago

I agree there are several types that are identical and could be combined into a single definition. I trying to add SocketMode support to an app that works with RTM and I'm having to write little convertor function to map slackevent.Something to slack.Something rather than just having a single definition.