Handle null value in JSONTime - Githubissues

slack-go / slack

Slack API in Go, originally by @nlopes; Maintainers needed, contact @parsley42

https://pkg.go.dev/github.com/slack-go/slack

BSD 2-Clause "Simplified" License

4.64k stars 1.13k forks source link

Handle null value in JSONTime #1106

Closed rusq closed 2 years ago

rusq commented 2 years ago

Handle the NULL value, when API returns "timestamp": null

It returns JSONTime(0) in this case.

Pull Request Guidelines

These are recommendations for pull requests. They are strictly guidelines to help manage expectations.

PR preparation

Run make pr-prep from the root of the repository to run formatting, linting and tests.

API changes

Since API changes have to be maintained they undergo a more detailed review and are more likely to require changes.

no tests, if you're adding to the API include at least a single test of the happy case.
If you can accomplish your goal without changing the API, then do so.
dependency changes. updates are okay. adding/removing need justification.

Examples of API changes that do not meet guidelines:

in library cache for users. caches are use case specific.
Convenience methods for Sending Messages, update, post, ephemeral, etc. consider opening an issue instead.