Closed andyhaskell closed 1 year ago
@kanata2 No problem! Btw it looks like in the 1.17 tests, TestGetRTMInfo
is failing. I haven't used this CI system before, so I was wondering, is there a way to restart that build? At least the wording there makes it sound like a transient issue
Actually, this test is so fraky... I understood test failure is not related to this changes, so I'll merge.
This PR adds support for deserializing file_change, file_deleted, file_shared, and file_unshared events from the Slack Events API
Pull Request Guidelines
These are recommendations for pull requests. They are strictly guidelines to help manage expectations.
PR preparation
Run
make pr-prep
from the root of the repository to run formatting, linting and tests.Should this be an issue instead
API changes
Since API changes have to be maintained they undergo a more detailed review and are more likely to require changes.
Examples of API changes that do not meet guidelines: