Added new FileUploadV2 function to avoid server side file timeouts

slack-go / slack

Slack API in Go, originally by @nlopes; Maintainers needed, contact @parsley42

https://pkg.go.dev/github.com/slack-go/slack

BSD 2-Clause "Simplified" License

4.64k stars 1.13k forks source link

Added new FileUploadV2 function to avoid server side file timeouts #1130

Closed sarthakkothari closed 1 year ago

sarthakkothari commented 1 year ago

Linking issue

This PR solves for - https://github.com/slack-go/slack/issues/1108 Implements the methods suggested in - https://github.com/slackapi/python-slack-sdk/releases/tag/v3.19.0

Need to account for nil interface because slack doesn't give SlackResponse or any json response for that matter when uploading file via post to GetUploadURLExternal's UploadURL

sarthakkothari commented 1 year ago

@kanata2 making a PR for the first time, how do I request your review/add label?

kanata2 commented 1 year ago

@sarthakkothari Sorry for delay. Will review within a few days. 🙏