slack-go / slack

Slack API in Go, originally by @nlopes; Maintainers needed, contact @parsley42
https://pkg.go.dev/github.com/slack-go/slack
BSD 2-Clause "Simplified" License
4.63k stars 1.12k forks source link

add datetimepicker component #1145

Closed hussachai closed 1 year ago

hussachai commented 1 year ago

This is a new component that Slack supports Datetimepicker where date and time components are in the same row. This new component takes number which I think it should be int64 for golang because Go's epoch API returns int64 data type. Since datetimepicker takes two columns, it's not supported in Accessory. So, I don't include it as part of Section serialization/deserialization.

PS. Sorry I deleted and restored a couple times. First didn't realize that I pushed the upstream, then I changed my mind because I tested it and it's working as expected.

Pull Request Guidelines

These are recommendations for pull requests. They are strictly guidelines to help manage expectations.

PR preparation

Run make pr-prep from the root of the repository to run formatting, linting and tests.

Should this be an issue instead
API changes

Since API changes have to be maintained they undergo a more detailed review and are more likely to require changes.

Examples of API changes that do not meet guidelines:
Houndie commented 1 year ago

Thank you for doing this! Saved me some time for doing it myself <3