Implement context-aware RunEventLoop

slack-go / slack

Slack API in Go, originally by @nlopes; Maintainers needed, contact @parsley42

https://pkg.go.dev/github.com/slack-go/slack

BSD 2-Clause "Simplified" License

4.63k stars 1.12k forks source link

Implement context-aware RunEventLoop #1169

Closed lololozhkin closed 1 year ago

lololozhkin commented 1 year ago

implemented RunEventLoopContext method. now socketmodehandler will react on context cancellation

PR preparation

[x] Run make pr-prep from the root of the repository to run formatting, linting and tests.

lololozhkin commented 1 year ago

resolves slack-go/slack#1162

lololozhkin commented 1 year ago

Hi, added context to run method on socketmodehandler. make pr-prep was successful. Could you please merge it in master, to resolve slack-go/slack#1162 ?

lololozhkin commented 1 year ago

and, could you please approve workflow run? It's my first PR..

sbansal7 commented 1 year ago

Hi @lololozhkin any chance you could respond to the above comment? -Thanks!

kanata2 commented 1 year ago

Thanks! LGTM 👍