Add slack connect events & tests - Githubissues

slack-go / slack

Slack API in Go, originally by @nlopes; Maintainers needed, contact @parsley42

https://pkg.go.dev/github.com/slack-go/slack

BSD 2-Clause "Simplified" License

4.6k stars 1.11k forks source link

Add slack connect events & tests #1262

Closed Birtato closed 4 months ago

Birtato commented 4 months ago

Pull Request Guidelines

These are recommendations for pull requests. They are strictly guidelines to help manage expectations.

PR preparation

Run make pr-prep from the root of the repository to run formatting, linting and tests.

Should this be an issue instead

[ ] is it a convenience method? (no new functionality, streamlines some use case)
[ ] exposes a previously private type, const, method, etc.
[x] is it application specific (caching, retry logic, rate limiting, etc)
[ ] is it performance related.

API changes

Since API changes have to be maintained they undergo a more detailed review and are more likely to require changes.

no tests, if you're adding to the API include at least a single test of the happy case.
If you can accomplish your goal without changing the API, then do so.
dependency changes. updates are okay. adding/removing need justification.

Examples of API changes that do not meet guidelines:

in library cache for users. caches are use case specific.
Convenience methods for Sending Messages, update, post, ephemeral, etc. consider opening an issue instead.

Birtato commented 4 months ago

Thanks, @parsley42. Anything else needed on my end to be able to finish up the review and merge for this change?