slack-go / slack

Slack API in Go, originally by @nlopes; Maintainers needed, contact @parsley42
https://pkg.go.dev/github.com/slack-go/slack
BSD 2-Clause "Simplified" License
4.6k stars 1.11k forks source link

chore: enable to upload file without channel param #1286

Open nakamasato opened 2 months ago

nakamasato commented 2 months ago
Pull Request Guidelines

These are recommendations for pull requests. They are strictly guidelines to help manage expectations.

PR preparation

Run make pr-prep from the root of the repository to run formatting, linting and tests.

Should this be an issue instead
API changes

Since API changes have to be maintained they undergo a more detailed review and are more likely to require changes.

Examples of API changes that do not meet guidelines:
Ref
0xdeafcafe commented 3 weeks ago

Anything I can do to help push this through? Would be really useful for us.

nakamasato commented 2 weeks ago

@0xdeafcafe Thanks!I wanted to upload a file without sending out to the channel but after roughly checking the API, i'm not very sure if it's possible from the api perspective and kept my pr draft. I saw you already made your own PR. Let's see there!

0xdeafcafe commented 2 weeks ago

@0xdeafcafe Thanks!I wanted to upload a file without sending out to the channel but after roughly checking the API, i'm not very sure if it's possible from the api perspective and kept my pr draft. I saw you already made your own PR. Let's see there!

We're using a fork of the repo with my PR on production at the moment, so I can confirm it works thankfully.