Open nakamasato opened 2 months ago
Anything I can do to help push this through? Would be really useful for us.
@0xdeafcafe Thanks!I wanted to upload a file without sending out to the channel but after roughly checking the API, i'm not very sure if it's possible from the api perspective and kept my pr draft. I saw you already made your own PR. Let's see there!
@0xdeafcafe Thanks!I wanted to upload a file without sending out to the channel but after roughly checking the API, i'm not very sure if it's possible from the api perspective and kept my pr draft. I saw you already made your own PR. Let's see there!
We're using a fork of the repo with my PR on production at the moment, so I can confirm it works thankfully.
Pull Request Guidelines
These are recommendations for pull requests. They are strictly guidelines to help manage expectations.
PR preparation
Run
make pr-prep
from the root of the repository to run formatting, linting and tests.Should this be an issue instead
API changes
Since API changes have to be maintained they undergo a more detailed review and are more likely to require changes.
Examples of API changes that do not meet guidelines:
Ref