search

slack-rs / slack-api-schemas

Schemas for the Slack API
1 stars 11 forks source link

untagged profile fields variant #2

Closed dten closed 7 years ago

dten commented 7 years ago

profile fiends can be null, [], or an object representing a map there is no type field that indicates which it will be so it needs to use new untagged type

mthjones commented 7 years ago

Hmm, I'm thinking now that the proper way to fix this is to actually implement a custom deserializer in the generation for that one object, as @compressed mentioned.

Fixing it by changing the schemas would be a breaking change, and then another breaking change to change back, which isn't ideal.

mthjones commented 7 years ago

I can make that change if you'd like. It's a bit grosser to implement. 😬

dten commented 7 years ago

changing schema agree is not best so closing