Closed mthjones closed 8 years ago
I dropped the newtype wrapper and things work fine. The only issue is if the trait in in scope, in which case you should get an ambiguous method call error message on compile, and can use UFCS to call the correct method.
Might not be necessary for this PR, but we should probably add an example snippet with hyper somewhere.
I think being flexible on the http client is nice, and having our own mocking is a win. Looks pretty nice to me.
Side note: we should probably pick a stable point in all the refactoring soon and get a release out to crates.io soonish, there are a lot of changes since the last release.
Sorry for the delay! Went through a move at the beginning of the month and have been tied up with a few big projects at work. I'm going to resolve the conflict that came up and merge this in tonight. Will cut a 0.15.0
release after merge.
Motivation
yup-hyper-mock
as a dependency, as it was causing dependency version issues. The tests are simplified as a result.Breaking Changes
cc: @BenTheElder @kiyoto