search

slack-ruby / slack-api-ref

This is a maintained, machine-readable version of the Slack API Docs.
MIT License
42 stars 15 forks source link

Set up Rubocop #58

Closed kstole closed 2 years ago

kstole commented 2 years ago

Sets up Rubocop to enforce code consistency.

kstole commented 2 years ago

I'm guessing we want to set this up as a CI step. Would that be via GitHub Actions or Travis CI like slack-ruby-bot uses?

dblock commented 2 years ago

I'm guessing we want to set this up as a CI step. Would that be via GitHub Actions or Travis CI like slack-ruby-bot uses?

Yes. Or make it part of the validate.yml.

kstole commented 2 years ago

I'm guessing we want to set this up as a CI step. Would that be via GitHub Actions or Travis CI like slack-ruby-bot uses?

Yes. Or make it part of the validate.yml.

I've not actually worked w/ GitHub Actions before, but looks like a separate Workflow is similar to adding a job to validate. I went with the separate workflow to be in line with slack-ruby-client and because lint is different than what validate is trying to achieve