search

slack-ruby / slack-ruby-bot-server-events

Slack commands, interactive buttons, and events extension for slack-ruby-bot-server.
MIT License
71 stars 10 forks source link

Replace Travis CI with GHA #13

Closed crazyoptimist closed 2 years ago

crazyoptimist commented 2 years ago

close #12

crazyoptimist commented 2 years ago

Postgres test is failing and didn't find the reason. See here for the details. rake spec is failing because of connection problem to the postgres db. Everything else is green. @dblock ^

dblock commented 2 years ago

For postgres, see the changes I made in https://github.com/slack-ruby/slack-ruby-bot-server/commit/9be129f893fd72645306b928297a74e8e8b65cc1 in activerecord.rb to use an env variable (parse with ERB):

db_config = YAML.safe_load(
  ERB.new(File.read(
            File.expand_path('config/postgresql.yml', __dir__)
          )).result, [], [], true
)[ENV['RACK_ENV']]

then postgresql.yml gets url: <%= ENV["DATABASE_URL"] %> and DATABASE_URL is set in the GHA workflow.

crazyoptimist commented 2 years ago

Not sure if danger will go fine, it failed when I triggered with pull. Everything else is green.