search

slack-ruby / slack-ruby-bot-server-events

Slack commands, interactive buttons, and events extension for slack-ruby-bot-server.
MIT License
71 stars 10 forks source link

chore: replace danger token due to rotation #17

Closed crazyoptimist closed 1 year ago

dangerpr-bot commented 1 year ago
1 Warning
:warning: Unless you're refactoring existing code or improving documentation, please update CHANGELOG.md.

Here's an example of a CHANGELOG.md entry:

* [#17](https://github.com/slack-ruby/slack-ruby-bot-server-events/pull/17): Chore: replace danger token due to rotation - [@crazyoptimist](https://github.com/crazyoptimist).

Generated by :no_entry_sign: Danger

crazyoptimist commented 1 year ago

Not sure why it fails in ruby-2.7.2.

crazyoptimist commented 1 year ago

Another thing I wonder is that CI always uses mongoid latest version(8.0.3 as of now), no matter what version you specified in the workflow version matrix. I've checked the test logs for all cases and they all installed mongoid 8.0.3.

@dblock

dblock commented 1 year ago

Database versions should be locked down for where they auto-updated. Likely the cause of failures in the CI.

crazyoptimist commented 1 year ago

Fixed the mongoid version lock down, but it still fails in ruby-2.7.2. Even further, it's not about mongo, because tests fail also with postgres on the ruby version.

An error occurred while loading ./spec/slack-ruby-bot-server-events/config_spec.rb.
Failure/Error: require 'slack-ruby-bot-server'

SyntaxError:
  /home/debian/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/console-1.16.2/lib/console/progress.rb:77: syntax error, unexpected ')'
                        @output.info(@subject, ...)
                                                  ^
  /home/debian/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/console-1.16.2/lib/console/progress.rb:106: syntax error, unexpected end-of-input, expecting `end'
# ./lib/slack-ruby-bot-server-events.rb:3:in `require'
# ./lib/slack-ruby-bot-server-events.rb:3:in `<top (required)>'
# ./spec/spec_helper.rb:6:in `<top (required)>'
# ./spec/slack-ruby-bot-server-events/config_spec.rb:3:in `require'
# ./spec/slack-ruby-bot-server-events/config_spec.rb:3:in `<top (required)>'
crazyoptimist commented 1 year ago

Ended up dropping the ruby version 2.7.2. Everything is green with 2.6.2 and 3.1.0. Locally I also tried with mongoid 8.0.3 and ruby 3.1.3, turned green.

dblock commented 1 year ago

The 2.7.2 problem is https://github.com/socketry/console/issues/37.

Seems like Ruby 2.7.3 would have worked. Want to try?

crazyoptimist commented 1 year ago

You are right. I tried Ruby 2.7.3 on my machine and it turned green. But I think we are good enough with 2.6.2?

dblock commented 1 year ago

I think we wanted to have some more rubies coverage to find problems like these. The latest 2.7 is 2.7.7 I think. Leaving it as is also works for me.