Can't re-install SlackApp to SlackTeam

slack-ruby / slack-ruby-bot-server-sample

Sample app from slack-ruby-bot-server.

MIT License

2 stars 5 forks source link

Can't re-install SlackApp to SlackTeam #1

Closed huydangquoc closed 7 years ago

huydangquoc commented 7 years ago

Hi @dblock ,

While playing with "slack-ruby-bot-server-sample", I found that I can't re-install SlackApp to SlackTeam. Re-produce steps as below:

Pre-condition:

Slack bot server started and working properly.
Team registered successfully to Slack bot server.
chatbot is active in Team chat

Issue re-produce steps:

Open browser, connect to "https://.slack.com/apps/manage"
Choose our demo Slack App
Scroll down to "Remove App" red button and click it.

Observation:

error happens at server right away
try re-start server, still receive same error

Please help verify Huy Dang

huydangquoc commented 7 years ago

Hi @dblock ,

I try to dig deeper to source code and find that this line in service.rb of slack-ruby-bot-server cause above error screen shot 2016-10-17 at 08 29 17 Replace run_callbacks :error, team, server, e with run_callbacks :error, team, e and I'm able to re-install SlackApp to team

Hope this help. Huy Dang

dblock commented 7 years ago

Nice digging!

@huydangquoc Would you mind writing a test and submitting a pull request fixing this?

dblock commented 7 years ago

@huydangquoc This was already fixed in https://github.com/slack-ruby/slack-ruby-bot-server/commit/cfa14a9046cdef9f51a005b8203abd4104c31830, you probably pulling an older version of slack-ruby-bot-server. Change Gemfile to use ~> 0.4.0, retest and PR it here, please.

huydangquoc commented 7 years ago

@dblock I changed Gemfile as you suggestion and it worked. 👍 Thank you for your support. I should check latest version first, sorry for the inconvenience 😞

dblock commented 7 years ago

No worries @huydangquoc!

dblock commented 7 years ago

Do me a favor? Change it in https://github.com/slack-ruby/slack-ruby-bot-server-sample/blob/master/Gemfile#L5, run bundle update, and make a pull request?