search

slack-ruby / slack-ruby-bot-server

A library that enables you to write a complete Slack bot service with Slack button integration, in Ruby.
MIT License
268 stars 74 forks source link

Add support for OAuth v2. #132

Closed dblock closed 3 years ago

dblock commented 3 years ago

Closes #131

dblock commented 3 years ago

Very awesome When are you going to push this to gem registry? Or should I try this with just git repo?

Try with github: 'dblock/slack-ruby-bot-server', branch: 'oauth-v2'. I'll merge and release shortly, but it would be good to catch bugs before releasing.

dblock commented 3 years ago

Note that I did the changes for my demo in https://github.com/slack-ruby/slack-ruby-bot-server-events-sample/commit/8fdd9ebf120aca900f59511a7c2ba15ae3559148.

crazyoptimist commented 3 years ago

Got ya!

crazyoptimist commented 3 years ago

I've verified that this is working with new slack apps. https://github.com/CrazyOptimist/slack-rails-bot-starter/pull/3 I just need to update README and the interactive message templates to the new one. You're awesome!

crazyoptimist commented 3 years ago

One more thing, https://github.com/slack-ruby/slack-ruby-bot-server/blob/13f330c36b9b7d7843c478877415a565e1be5d39/lib/slack-ruby-bot-server/app.rb#L35 SlackRubyBotServer::App#configure_global_aliases! is referencing Slack::Ruby::Bot FYI, I removed below lines from my config.ru

SlackRubyBotServer::App.instance.prepare!
SlackRubyBotServer::Service.start!
dblock commented 3 years ago

configure_global_aliases!

Thanks! Removing.