search

slack-ruby / slack-ruby-bot-server

A library that enables you to write a complete Slack bot service with Slack button integration, in Ruby.
MIT License
268 stars 74 forks source link

Bot doesn't handle being removed from the last Organization on Slack side #152

Open Altonymous opened 1 year ago

Altonymous commented 1 year ago

Get the following error after I've removed the App from all Organizations when hitting the api/status end point. Not sure how or where this is getting called?

Side note: I tried cloning the repo and couldn't get the specs to run. (Failed on Bundler.require in the spec_helper.rb)


12:32:33 web.1  | E, [2022-10-28T12:32:33.241358 #55405] ERROR -- : Slack::Web::Api::Errors::AccountInactive: account_inactive
12:32:33 web.1  |   ~/.gem/ruby/3.1.2/gems/slack-ruby-client-2.0.0/lib/slack/web/faraday/response/raise_error.rb:19:in `on_complete'
12:32:33 web.1  |   ~/.gem/ruby/3.1.2/gems/faraday-2.6.0/lib/faraday/middleware.rb:18:in `block in call'
12:32:33 web.1  |   ~/.gem/ruby/3.1.2/gems/faraday-2.6.0/lib/faraday/response.rb:42:in `on_complete'
12:32:33 web.1  |   ~/.gem/ruby/3.1.2/gems/faraday-2.6.0/lib/faraday/middleware.rb:17:in `call'
12:32:33 web.1  |   ~/.gem/ruby/3.1.2/gems/faraday-2.6.0/lib/faraday/request/url_encoded.rb:25:in `call'
12:32:33 web.1  |   ~/.gem/ruby/3.1.2/gems/faraday-multipart-1.0.4/lib/faraday/multipart/middleware.rb:28:in `call'```
dblock commented 1 year ago

The status endpoint is here. This error comes from calling Team.ping. The stack should contain that at the very least.

dblock commented 1 year ago

@crazyoptimist if you want a challenging workitem after you release this is the one, I see it a lot in production where admins disable access to a bot in their settings, bot doesn't go offline properly and can't be restarted if reinstalled without bouncing the entire app

The api/status doesn't handle AccountInactive error appropriately either.