Fixed expectation failures when client.say is passed extra arguments

slack-ruby / slack-ruby-bot

The easiest way to write a Slack bot in Ruby.

MIT License

1.12k stars 187 forks source link

Fixed expectation failures when client.say is passed extra arguments #160

Closed gcraig99 closed 7 years ago

gcraig99 commented 7 years ago

Fixed expectation failures when client.say is passed extra arguments such as as_user: true Added test cases for this situation as well. Closes #159

dblock commented 7 years ago

This is great, see my comment re yml fix and it can be merged.

As a followup item, maybe we should add support for taking a hash in respond_with_slack_message for exact expectation?

gcraig99 commented 7 years ago

I was thinking that I'd add extra expectations that would allow for parameter matching, so you could have a spec that makes sure a command is using as_user: true, or whatever other parameters are supported.