Update Syntaxes for Ruby 2.5

slack-ruby / slack-ruby-bot

The easiest way to write a Slack bot in Ruby.

MIT License

1.12k stars 187 forks source link

Update Syntaxes for Ruby 2.5 #186

Closed hanasuke closed 6 years ago

hanasuke commented 6 years ago

When I want to use this gem in Ruby 2.5.1, Rubocop issued some warnings. So, I fixed some issues.

Add magic comment # frozen_string_literal: true for all files
Replace to safe navigation operator &. from conditional expr like hoge && hoge.foo

dblock commented 6 years ago

This breaks compatibility with every previous version, so unfortunately it's a bit premature, thx. You can force target Rubocop to a previous version to remove the warnings and add 2.5.0 to the build matrix.