Allow frozen string in hooks message

slack-ruby / slack-ruby-bot

The easiest way to write a Slack bot in Ruby.

MIT License

1.12k stars 187 forks source link

Closed jnsya closed 6 years ago

jnsya commented 6 years ago

In our code we currently use frozen_string_literal: true. This causes an error because the slack-ruby-bot is trying to mutate a string.

We only fixed and created a test for the example we found, but there might be more.

Would you be open to using frozen_string_literal by default? I would be open to do that if you want.

dangerpr-bot commented 6 years ago

	1 Error
:no_entry_sign:	One of the lines below found in CHANGELOG.md doesn’t match the expected format. Please make it look like the other lines, pay attention to periods and spaces.

* Allow frozen string in Hooks::Message - [@jonosenior](https://github.com/jonosenior)

Generated by :no_entry_sign: danger

dblock commented 6 years ago

Thanks for this.