Exclude development dependency from public RSpec config

slack-ruby / slack-ruby-bot

The easiest way to write a Slack bot in Ruby.

MIT License

1.12k stars 187 forks source link

Exclude development dependency from public RSpec config #258

Closed dikond closed 4 years ago

dikond commented 4 years ago

Closes #257

I can confirm that it fixes the problem I described in the linked issue.

dikond commented 4 years ago

@dblock I've updated UPGRADING.md and also checked the RSpec setup of the gems you've mentioned. These two have their own VCR config which is loaded after slack-ruby-bot/rspec so they wouldn't need to change on upgrade.

dikond commented 4 years ago

@dblock I've updated the CONTRIBUTING.md and bumped up the version, please take a look 🙂

dblock commented 4 years ago

Thank you, merged.