search

slack-ruby / slack-ruby-client

A Ruby and command-line client for the Slack Web, Real Time Messaging and Event APIs.
MIT License
1.19k stars 215 forks source link

Force VCR to include headers in unmatched request error reports #392

Closed chrisbloom7 closed 2 years ago

chrisbloom7 commented 2 years ago

Followup to https://github.com/slack-ruby/slack-ruby-client/pull/387#discussion_r764321209

Patches VCR unhandled HTTP request error reporter to always include headers, since we're using a custom header matcher.

dangerpr-bot commented 2 years ago
1 Warning
:warning: Unless you're refactoring existing code or improving documentation, please update CHANGELOG.md.
1 Message
:book: We really appreciate pull requests that demonstrate issues, even without a fix. That said, the next step is to try and fix the failing tests!

Here's an example of a CHANGELOG.md entry:

* [#392](https://github.com/slack-ruby/slack-ruby-client/pull/392): Force vcr to include headers in unmatched request error reports - [@chrisbloom7](https://github.com/chrisbloom7).

Generated by :no_entry_sign: Danger