search

slack-ruby / slack-ruby-client

A Ruby and command-line client for the Slack Web, Real Time Messaging and Event APIs.
MIT License
1.19k stars 214 forks source link

Update real_time.rake to remove outdated event hooks and organize alphabetically #424

Closed kstole closed 1 year ago

kstole commented 1 year ago

The slack:real_time:api:update task currently doesn't touch previous hooks and only prepends new event handler templates at the top of the store. The result is that many of the hooks currently in the stores are for Slack events that no longer exist or have outdated documentation. Additionally, there is no consistent ordering.

This PR makes the task more intelligent to extract all the current hooks and reuse only the hooks themselves while always generating fresh documentation and arranging the hooks in alphabetical order. Any hooks not matching the current Slack API ref are discarded.

This sets up updating some hook implementations for changes in #423

dangerpr-bot commented 1 year ago
1 Warning
:warning: There're library changes, but not tests. That's OK as long as you're refactoring existing code.

Generated by :no_entry_sign: Danger