search

slack-ruby / slack-ruby-client

A Ruby and command-line client for the Slack Web, Real Time Messaging and Event APIs.
MIT License
1.21k stars 214 forks source link

Why is websocket-driver a hard dependency? #431

Closed blowfishpro closed 1 year ago

blowfishpro commented 1 year ago

It looks like it was added to support celluloid, but it was only loaded by the optional celluloid code (celluloid itself was an optional dependency), and the celluloid code has since been removed. As far as I can tell it's not loaded anywhere else.

dblock commented 1 year ago

You're probably right, Is it not something used by bringing in async-websocket? Please contribute removing it!

I would run integration tests with an API token to make sure it's not a transitive dependency somewhere.

blowfishpro commented 1 year ago

I still need to set up a Slack workspace and run the integration tests but it looks like the unit tests are passing.

dblock commented 1 year ago

We do have a token and run integration tests against Slack here in CI, so don't worry about it too much.

ambethia commented 1 year ago

This is a blocker for me right now trying to update some other dependencies in an app.

dblock commented 1 year ago

@ambethia Nobody picked this up, please contribute!

blowfishpro commented 1 year ago

I have the code it's just not pushed. I can do that now.