Integration tests run more than integration tests & don't skip in GitHub Actions - Githubissues

slack-ruby / slack-ruby-client

A Ruby and command-line client for the Slack Web, Real Time Messaging and Event APIs.

MIT License

1.21k stars 216 forks source link

Integration tests run more than integration tests & don't skip in GitHub Actions #444

Closed duffn closed 1 year ago

duffn commented 1 year ago

There are two issues here:

The integration test GitHub Action job https://github.com/slack-ruby/slack-ruby-client/blob/9d525298c5f30e0b6b80d6db5a1517467e66f593/.github/workflows/integration_test.yml runs all of the tests. See 467 examples run here: https://github.com/slack-ruby/slack-ruby-client/actions/runs/4427350917/jobs/7764813688
The skip check in the integration test spec https://github.com/slack-ruby/slack-ruby-client/blob/9d525298c5f30e0b6b80d6db5a1517467e66f593/spec/integration/integration_spec.rb#L5 works locally but not in GitHub Actions.

I can look at these.