search

slack-ruby / slack-ruby-client

A Ruby and command-line client for the Slack Web, Real Time Messaging and Event APIs.
MIT License
1.19k stars 214 forks source link

Add `Slack::Messages::Formatting#escape` #454

Closed marfoldi closed 1 year ago

marfoldi commented 1 year ago

Escaping control characters (&, <, and >) in messages as described in https://api.slack.com/reference/surfaces/formatting#escaping.

dblock commented 1 year ago

Looks like you have unrelated datastore API changes here, mind splitting them out? They will need their own CHANGELOG entry. Thanks!

marfoldi commented 1 year ago

Looks like you have unrelated datastore API changes here, mind splitting them out? They will need their own CHANGELOG entry. Thanks!

Sure, I'll. Maybe it's worthwhile to update https://github.com/slack-ruby/slack-ruby-client/blob/master/CONTRIBUTING.md#update-slack-web-api as well. 😉

dblock commented 1 year ago

Looks like you have unrelated datastore API changes here, mind splitting them out? They will need their own CHANGELOG entry. Thanks!

Sure, I'll. Maybe it's worthwhile to update https://github.com/slack-ruby/slack-ruby-client/blob/master/CONTRIBUTING.md#update-slack-web-api as well. 😉

Please!

dblock commented 1 year ago

Merged, thanks. Care to PR the web API update?

marfoldi commented 1 year ago

Merged, thanks. Care to PR the web API update?

Yess!