search

slack-ruby / slack-ruby-client

A Ruby and command-line client for the Slack Web, Real Time Messaging and Event APIs.
MIT License
1.21k stars 214 forks source link

Changes by create-pull-request action #459

Closed github-actions[bot] closed 1 year ago

github-actions[bot] commented 1 year ago

Automated changes by create-pull-request GitHub action

dblock commented 1 year ago

@duffn We just need not to open a PR when there are no changes. Remove the whole dummy file thing and I think it will be good.

duffn commented 1 year ago

I tried that last night but still got the same result. I'll keep poking at it. Feel free to disable the cron/close the PR if you like until I can get it straightened out.

dblock commented 1 year ago

I tried that last night but still got the same result. I'll keep poking at it. Feel free to disable the cron/close the PR if you like until I can get it straightened out.

Need help?

  1. Get rid of https://github.com/slack-ruby/slack-ruby-client/blob/master/.github/workflows/update_api.yml#L22 that creates a txt file every time.
  2. Get rid of the initial pull request.
  3. Make the title of the PR the same every time, e.g. "Updated Slack API"

If there are no code changes, there will be no new/updated PR. By default the GHA will search only open issues, so if there's no issue it will open a new one, or update an existing open one.

duffn commented 1 year ago

Yes, which is what I tried here a couple of days ago. https://github.com/duffn/slack-ruby-client-dev/actions/runs/4559721112/jobs/8043970827 Maybe something with the submodule checkout in the pipeline but then also in the Rake task too. I may have time to mess with it this weekend.

dblock commented 1 year ago

Yes, which is what I tried here a couple of days ago. https://github.com/duffn/slack-ruby-client-dev/actions/runs/4559721112/jobs/8043970827 Maybe something with the submodule checkout in the pipeline but then also in the Rake task too. I may have time to mess with it this weekend.

Interestingly, I wasn't able to reproduce this with your branch.

Auto-merging methods/chat/chat.postEphemeral.json
CONFLICT (add/add): Merge conflict in methods/chat/chat.postEphemeral.json

This is odd. This file isn't modified in your repo.

You probably want to rewind your master to match the upstream and then make your changes on a branch. Also, if you want to just make a PR that should fix the job, just go for it and we can see what happens.

duffn commented 1 year ago

Yeah, I reset to master before trying all of that. Anyway, let's see what happens here https://github.com/slack-ruby/slack-ruby-client/pull/462

duffn commented 1 year ago

Same issue, I'll try to look into it soon.

dblock commented 1 year ago

@duffn https://github.com/slack-ruby/slack-ruby-client/pull/464