Closed dblock closed 1 year ago
1 Warning | |
---|---|
:warning: | Unless you're refactoring existing code or improving documentation, please update CHANGELOG.md. |
Here's an example of a CHANGELOG.md entry:
* [#464](https://github.com/slack-ruby/slack-ruby-client/pull/464): Fix: fetch entire depth of commits to avoid detached head - [@dblock](https://github.com/dblock).
Generated by :no_entry_sign: Danger
@duffn
Using
actions/checkout@v3
with defaults checks out a detached HEAD atdepth: 1
. When you try togit submodule foreach git pull origin master
it will cause a conflict with the detached HEAD.To reproduce:
Here's a successful run, https://github.com/dblock/slack-ruby-client/actions/runs/4602617417 and an issue created from the change, https://github.com/dblock/slack-ruby-client/pull/2.
Needs a CHANGELOG update on top.