search

slack-ruby / slack-ruby-client

A Ruby and command-line client for the Slack Web, Real Time Messaging and Event APIs.
MIT License
1.19k stars 214 forks source link

Update API from slack-api-ref@bc54564 #504

Closed github-actions[bot] closed 5 months ago

github-actions[bot] commented 8 months ago

Update API from slack-api-ref. Rev: bc54564 Date: 2024-01-30

saimedhi commented 5 months ago

@dblock, I believe this bot is failing to update the changelog. Please correct me if I'm mistaken. I've implemented a similar bot for opensearch-py, and everything else seems to be working correctly except for the changelog update.

dangerpr-bot commented 5 months ago
1 Warning
:warning: There're library changes, but not tests. That's OK as long as you're refactoring existing code.

Generated by :no_entry_sign: Danger

dblock commented 5 months ago

@saimedhi good catch, I believe the problem is in peter-evans/create-pull-request@v5 that now does a Resetting working base branch 'master', so when it updates CHANGELOG it doesn't push the update onto the right branch.

Fixed in https://github.com/slack-ruby/slack-ruby-client/commit/015f615fa18f85073a26e4a316f94f54565a7398

github-actions[bot] commented 5 months ago

Pull Request Test Coverage Report for Build 7718744896

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/slack/web/api/endpoints/functions.rb 13 14 92.86%
<!-- Total: 36 37 97.3% -->
Totals Coverage Status
Change from base Build 7718739724: -0.5%
Covered Lines: 5054
Relevant Lines: 5703
💛 - Coveralls
coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 7718744896

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/slack/web/api/endpoints/functions.rb 13 14 92.86%
<!-- Total: 36 37 97.3% -->
Totals Coverage Status
Change from base Build 7718739724: -0.5%
Covered Lines: 5054
Relevant Lines: 5703
💛 - Coveralls