search

slack-ruby / slack-ruby-client

A Ruby and command-line client for the Slack Web, Real Time Messaging and Event APIs.
MIT License
1.19k stars 214 forks source link

Slack::Event::Request#verify! should use secure_compare #512

Open mintuhouse opened 3 months ago

mintuhouse commented 3 months ago

https://github.com/slack-ruby/slack-ruby-client/blob/9e6d1171aecfb89d11ce55fb010cc3370666cd01/lib/slack/events/request.rb#L62

if using active_support something like ActiveSupport::SecurityUtils.secure_compare

dblock commented 3 months ago

Good point, want to PR something along those lines @mintuhouse?