CI: Try to run bundle install just once

slack-ruby / slack-ruby-client

A Ruby and command-line client for the Slack Web, Real Time Messaging and Event APIs.

MIT License

1.21k stars 214 forks source link

CI: Try to run bundle install just once #517

Closed olleolleolle closed 3 months ago

olleolleolle commented 3 months ago

This PR moves the environment variable-setting Step to before the "setup Ruby" step.

The Setup Ruby step does a bundle install.

That means that we can remove the explicit bundle install later on the file.

dangerpr-bot commented 3 months ago

	1 Warning
:warning:	Unless you're refactoring existing code or improving documentation, please update CHANGELOG.md.

Here's an example of a CHANGELOG.md entry:

* [#517](https://github.com/slack-ruby/slack-ruby-client/pull/517): Ci: try to run bundle install just once - [@olleolleolle](https://github.com/olleolleolle).

Generated by :no_entry_sign: Danger

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 9777332057

Details

0 of 0 changed or added relevant lines in 0 files are covered.
30 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.08%) to 89.161%

Files with Coverage Reduction	New Missed Lines	%
spec/slack/real_time/concurrency/clients/async_spec.rb	1	87.5%
spec/slack/real_time/concurrency/with_concurrency_spec.rb	1	80.0%
lib/slack/real_time/concurrency/async.rb	28	1.39%
<!--	Total:	30	-->

Totals
Change from base Build 7789505062:	-0.08%
Covered Lines:	5092
Relevant Lines:	5711

💛 - Coveralls

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 9777332057

Details

0 of 0 changed or added relevant lines in 0 files are covered.
30 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.08%) to 89.161%

Files with Coverage Reduction	New Missed Lines	%
spec/slack/real_time/concurrency/clients/async_spec.rb	1	87.5%
spec/slack/real_time/concurrency/with_concurrency_spec.rb	1	80.0%
lib/slack/real_time/concurrency/async.rb	28	1.39%
<!--	Total:	30	-->

Totals
Change from base Build 7789505062:	-0.08%
Covered Lines:	5092
Relevant Lines:	5711

💛 - Coveralls

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 9777332057

Details

0 of 0 changed or added relevant lines in 0 files are covered.
30 unchanged lines in 3 files lost coverage.
Overall coverage increased (+0.002%) to 89.239%

Files with Coverage Reduction	New Missed Lines	%
spec/slack/real_time/concurrency/clients/async_spec.rb	1	87.5%
spec/slack/real_time/concurrency/with_concurrency_spec.rb	1	80.0%
lib/slack/real_time/concurrency/async.rb	28	1.39%
<!--	Total:	30	-->

Totals
Change from base Build 7789505062:	0.002%
Covered Lines:	5100
Relevant Lines:	5715

💛 - Coveralls

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 9777332057

Details

0 of 0 changed or added relevant lines in 0 files are covered.
30 unchanged lines in 3 files lost coverage.
Overall coverage increased (+0.002%) to 89.239%

Files with Coverage Reduction	New Missed Lines	%
spec/slack/real_time/concurrency/clients/async_spec.rb	1	87.5%
spec/slack/real_time/concurrency/with_concurrency_spec.rb	1	80.0%
lib/slack/real_time/concurrency/async.rb	28	1.39%
<!--	Total:	30	-->

Totals
Change from base Build 7789505062:	0.002%
Covered Lines:	5100
Relevant Lines:	5715

💛 - Coveralls

dblock commented 3 months ago

Looks good, thanks.