Support basic Markdown formatting

slack-ruby / slack-ruby-client

A Ruby and command-line client for the Slack Web, Real Time Messaging and Event APIs.

MIT License

1.19k stars 215 forks source link

Support basic Markdown formatting #519

Closed nbgoodall closed 2 weeks ago

nbgoodall commented 2 weeks ago

This PR adds basic support for Slack's markdown formatting, specifically bold, ~~strikethrough~~ and links. Non-supported features like headings and tables are left as-is.

Closes #249.

dangerpr-bot commented 2 weeks ago

	1 Error
:no_entry_sign:	Please put back the `* Your contribution here.` line into CHANGELOG.md.

Generated by :no_entry_sign: Danger

coveralls commented 2 weeks ago

Pull Request Test Coverage Report for Build 9805256502

Details

13 of 13 (100.0%) changed or added relevant lines in 2 files are covered.
67 unchanged lines in 8 files lost coverage.
Overall coverage decreased (-1.2%) to 88.017%

Files with Coverage Reduction	New Missed Lines	%
spec/slack/real_time/concurrency/clients/async_spec.rb	1	87.5%
spec/slack/real_time/concurrency/with_concurrency_spec.rb	1	80.0%
lib/slack/web/api/errors/too_many_requests_error.rb	3	72.73%
spec/slack/slack_spec.rb	5	88.37%
lib/slack/web/pagination/cursor.rb	5	83.33%
spec/slack/web/api/pagination/cursor_spec.rb	5	88.89%
spec/slack/web/api/endpoints/custom_specs/chat_spec.rb	19	77.65%
lib/slack/real_time/concurrency/async.rb	28	1.39%
<!--	Total:	67	-->

Totals
Change from base Build 9781149632:	-1.2%
Covered Lines:	5039
Relevant Lines:	5725

💛 - Coveralls

coveralls commented 2 weeks ago

Pull Request Test Coverage Report for Build 9805349158

Details

13 of 13 (100.0%) changed or added relevant lines in 2 files are covered.
28 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.05%) to 89.186%

Files with Coverage Reduction	New Missed Lines	%
lib/slack/real_time/concurrency/async.rb	28	1.39%
<!--	Total:	28		-->

Totals
Change from base Build 9781149632:	-0.05%
Covered Lines:	5105
Relevant Lines:	5724

💛 - Coveralls

coveralls commented 2 weeks ago

Pull Request Test Coverage Report for Build 9805349158

Details

13 of 13 (100.0%) changed or added relevant lines in 2 files are covered.
28 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.05%) to 89.186%

Files with Coverage Reduction	New Missed Lines	%
lib/slack/real_time/concurrency/async.rb	28	1.39%
<!--	Total:	28		-->

Totals
Change from base Build 9781149632:	-0.05%
Covered Lines:	5105
Relevant Lines:	5724

💛 - Coveralls

coveralls commented 2 weeks ago

Pull Request Test Coverage Report for Build 9805349158

Details

13 of 13 (100.0%) changed or added relevant lines in 2 files are covered.
28 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.02%) to 89.263%

Files with Coverage Reduction	New Missed Lines	%
lib/slack/real_time/concurrency/async.rb	28	1.39%
<!--	Total:	28		-->

Totals
Change from base Build 9781149632:	0.02%
Covered Lines:	5113
Relevant Lines:	5728