search

slack-samples / bolt-python-starter-template

A template for building Slack apps with Bolt for Python
MIT License
55 stars 17 forks source link

should we use ruff? #32

Open marcieltorres opened 9 months ago

marcieltorres commented 9 months ago

Hello everyone,

Nowadays I'm using ruff for my projects and it's been amazing.

Some projects: https://github.com/marcieltorres/safe-chat-slack-bot (it's a bot using Slack Bolt :) ) https://github.com/marcieltorres/python-boilerplate-project

So, what do you think about we add ruff on this template?

zimeg commented 8 months ago

Hey @marcieltorres 👋 Thanks for this suggestion! ruff seems like a really cool tool and we're interested in trying it on the Python templates. I totally believe that it's amazing.

Right now we might hold off on the replacement until the pycodestyle rules are implemented so certain lints are caught by ruff check - currently tracking this in astral-sh/ruff#2402 - but I think this'll be a great enhancement after that!

Talked with @WilliamBergamin about this too and great points were raised about consolidating the current .flake8 rules into the pyproject.toml which is always exciting! 🎉

buhtz commented 8 months ago

In my own projects I do combine several linters (in unit tests). I do run ruff (with --preview flag) as the first because it is the fastest one. After that all the others (pycodestyle, pylint, codespell) are in the line. See my code.