search

slack-theme / visual-studio-code

Slack Theme for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=felipe-mendes.slack-theme
MIT License
103 stars 18 forks source link

Icons in the outline view of sidebar #16

Closed pkazmier closed 4 years ago

pkazmier commented 4 years ago

Is it just me or does anyone else have issues with the icons in the outline view of the sidebar for these themes?

image

As a quick fix, I've added the symbolIcon keys to my workbench color customizations. I'm sure someone could get creative and pick different colors for the different icons, but this was good enough for me:

    "workbench.colorCustomizations": {
        "[Slack Theme Aubergine - NEW COLOR]": {
            "editor.foreground": "#383A42",
            "input.background": "#FFF",
            "input.border": "#DCDCE4",
            "input.foreground": "#000",
            "input.placeholderForeground": "#a0a0a0",
            "inputOption.activeBorder": "#3E313C",
            "inputValidation.errorBackground": "#F44C5E",
            "inputValidation.errorForeground": "#FFF",
            "inputValidation.infoBackground": "#6182b8",
            "inputValidation.infoForeground": "#FFF",
            "inputValidation.warningBackground": "#F6B555",
            "inputValidation.warningForeground": "#000",
            "symbolIcon.arrayForeground": "#c9b9c5",
            "symbolIcon.booleanForeground": "#c9b9c5",
            "symbolIcon.classForeground": "#c9b9c5",
            "symbolIcon.colorForeground": "#c9b9c5",
            "symbolIcon.constantForeground": "#c9b9c5",
            "symbolIcon.constructorForeground": "#c9b9c5",
            "symbolIcon.enumeratorForeground": "#c9b9c5",
            "symbolIcon.enumeratorMemberForeground": "#c9b9c5",
            "symbolIcon.eventForeground": "#c9b9c5",
            "symbolIcon.fieldForeground": "#c9b9c5",
            "symbolIcon.fileForeground": "#c9b9c5",
            "symbolIcon.folderForeground": "#c9b9c5",
            "symbolIcon.functionForeground": "#c9b9c5",
            "symbolIcon.interfaceForeground": "#c9b9c5",
            "symbolIcon.keyForeground": "#c9b9c5",
            "symbolIcon.keywordForeground": "#c9b9c5",
            "symbolIcon.methodForeground": "#c9b9c5",
            "symbolIcon.moduleForeground": "#c9b9c5",
            "symbolIcon.namespaceForeground": "#c9b9c5",
            "symbolIcon.nullForeground": "#c9b9c5",
            "symbolIcon.numberForeground": "#c9b9c5",
            "symbolIcon.objectForeground": "#c9b9c5",
            "symbolIcon.operatorForeground": "#c9b9c5",
            "symbolIcon.packageForeground": "#c9b9c5",
            "symbolIcon.propertyForeground": "#c9b9c5",
            "symbolIcon.referenceForeground": "#c9b9c5",
            "symbolIcon.snippetForeground": "#c9b9c5",
            "symbolIcon.stringForeground": "#c9b9c5",
            "symbolIcon.structForeground": "#c9b9c5",
            "symbolIcon.textForeground": "#c9b9c5",
            "symbolIcon.typeParameterForeground": "#c9b9c5",
            "symbolIcon.unitForeground": "#c9b9c5",
            "symbolIcon.variableForeground": "#c9b9c5",
        },
    },

Here is the result:

image

On a side note, I also tweaked the "black" foreground color to be a softer black. And, I also disliked the borders that were added to the input boxes, so I just took the Hoth settings to make those boxes look nicer.

felipemendes commented 4 years ago

I hadn't noticed these icons colors. The way you suggested it got much better. I appreciate your feedback and help @pkazmier.

The changes will already be applied :)