search

slack-theme / visual-studio-code

Slack Theme for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=felipe-mendes.slack-theme
MIT License
103 stars 18 forks source link

Unstaged file color very dim in the editor #30

Closed nikeshparajuli closed 3 years ago

nikeshparajuli commented 3 years ago

macOS 11.3.1 vscode 1.56.2

First of all, thank you so much for the theme. They are all very cool!

I noticed a small bug where most of the color palettes except Ochin and Dark show very whiteish color for files that have changed and are unstaged. As you can see, I'm using Aubergine and the filename text color looks completely normal after I stage my changes. I also checked out Ochin and it seems to handle this pretty well for both staged and unstaged files. Maybe we need a similar functionality for other ones. I hope you'll look into this.

Before staging changes: 1

After staging changes: 2

nikeshparajuli commented 3 years ago

I could also create a PR with the fix if you want.. unfortunately I don't have write access to the repo.

felipemendes commented 3 years ago

Hey, @nikeshparajuli Thanks for your feedback :)

Not sure why you can't open a PR, those access are grant to everyone. Could you please try it again? Or if you already know how to fix it, please tell me.

Otherwise, I will try to figure this out

nikeshparajuli commented 3 years ago

Ok just realized that I had to create a fork. I have opened a PR. Please note that only the first commit contains the fix to the issue. The second commit was needed to fix indentation issues. Apparently vscode didn't show them earlier.

felipemendes commented 3 years ago

This perfectly fit all issues. Just merged #31

nikeshparajuli commented 3 years ago

Awesome!