slack-theme / visual-studio-code

Slack Theme for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=felipe-mendes.slack-theme
MIT License
103 stars 18 forks source link

fixed light themes displaying white text I beam cursor #7

Open nimms opened 5 years ago

nimms commented 5 years ago

Hi I really liked these themes, but because they were set as dark themes in the project.json, vscode was displaying a white I-Beam text caret, making it difficult to keep track of my mouse.

felipemendes commented 5 years ago

Hi, @nimms. Happy to know you liked. At beginning they were set as light, but vscode set some buttons with dark gray color for light scheme. Therefore sidebar buttons won't be visible as you can see at issue #5 . I could not solve this problem cause it's default from vscode. I will try to figure this out or suggest this fix at vscode repo.

47205936-0f491800-d390-11e8-8c5e-9c9a66299cbf

nimms commented 5 years ago

Looks like a vscode problem. For ultimate theming, they shouldn't be setting interface colours off settings in the package.json, for precisely this reason. Thanks for the reply, for me, the loss of the text I-beam carat is probably a bigger issue given I never even noticed those little buttons previously!