Open slimes28 opened 3 months ago
Hi @slimes28 The following seems to be the simplest way to collect search params, the Bolt framework is tailored to interact with the Slack API which rarely uses these parameters
let urlParams: URLSearchParams = new URLSearchParams();
const params = req.url.split("?");
if (params.length > 1) {
urlParams = new URLSearchParams(params[1]);
}
🤔 Wondering if we might want to treat this as a possible enhancement such that these params can be accessed from the request object?
https://localhost:3000/greetings?name=you
const app = new App({
token: process.env.SLACK_BOT_TOKEN,
signingSecret: process.env.SLACK_SIGNING_SECRET,
customRoutes: [
{
path: '/greetings',
method: ['GET'],
handler: (req, res) => {
res.writeHead(200);
res.end(`Hello ${req.query.name}!`); // Hello you!
},
},
],
});
👋 It looks like this issue has been open for 30 days with no activity. We'll mark this as stale for now, and wait 10 days for an update or for further comment before closing this issue out. If you think this issue needs to be prioritized, please comment to get the thread going again! Maintainers also review issues marked as stale on a regular basis and comment or adjust status if the issue needs to be reprioritized.
🤔 Still thinking this'll be a good future enhancement so updating the label. Having req.query
set to an empty object and populated with parsed queries seems like expected behavior to me - similar to Express.js requests with defaults to the node:querystring.parse()
or URLSearchParams
parsing! For reference, here are current customRoutes
handlers.
👋 It looks like this issue has been open for 30 days with no activity. We'll mark this as stale for now, and wait 10 days for an update or for further comment before closing this issue out. If you think this issue needs to be prioritized, please comment to get the thread going again! Maintainers also review issues marked as stale on a regular basis and comment or adjust status if the issue needs to be reprioritized.
As this issue has been inactive for more than one month, we will be closing it. Thank you to all the participants! If you would like to raise a related issue, please create a new issue which includes your specific details and references this issue number.
Hello, Is this the only option to get search params in custom router or there is a better way? https://github.com/slackapi/bolt-js/issues/1325#issuecomment-1528326746