slackapi / bolt-python

A framework to build Slack apps using Python
https://slack.dev/bolt-python/
MIT License
1.03k stars 237 forks source link

Replace Flask-Sockets with aiohttp for testing #1012

Closed WilliamBergamin closed 6 months ago

WilliamBergamin commented 6 months ago

This PR bring the logic from slack-sdk #1445 to bolt python

Flask-Sockets is deprecated and it won't receive any fixes in the future, so it seems reasonable to replace it with some up-to-date library. aiohttp has been chosen since it was already presented as an optional requirement.

Category (place an x in each of the [ ])

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f150cfd) 91.76% compared to head (3a8f641) 91.76%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1012 +/- ## ======================================= Coverage 91.76% 91.76% ======================================= Files 181 181 Lines 6312 6312 ======================================= Hits 5792 5792 Misses 520 520 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.