Open WilliamBergamin opened 5 months ago
Attention: Patch coverage is 98.50000%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 91.97%. Comparing base (
2882708
) to head (fff7c9f
).
Files | Patch % | Lines |
---|---|---|
slack_bolt/request/internals.py | 93.10% | 2 Missing :warning: |
slack_bolt/context/base_context.py | 90.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@seratch @WilliamBergamin When will this PR be merged?
This PR includes all the changes from #986 aims to add support for custom functions in Bolt Python
Feedback
I'm looking for feedback on
Testing
This gist was created to show how to test these new feature, use it with the following steps
export SLACK_BOT_TOKEN=xoxb-...
export SLACK_APP_TOKEN=xapp-...
app.py
andasync_app.py
with the above source code b. Pull the latest PR branch of bolt python to your local c. Runscripts/build_pypi_package.sh
this will generate a.whl
in thedist/
folder d. (Optional) In your project set up a venv withpython -m venv .venv
andsource .venv/bin/activate
e.pip install global/path/to/bolt-python/dist/something.whl
f.pip install aiohttp
gpython app.py
orpython async_app.py
Category
slack_bolt.App
and/or its core componentsslack_bolt.async_app.AsyncApp
and/or its core componentsslack_bolt.adapter
/docs
Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.sh
after making the changes.