slackapi / bolt-python

A framework to build Slack apps using Python
https://slack.dev/bolt-python/
MIT License
1.02k stars 236 forks source link

pytype execution fails when using install_all_and_run_tests.sh #1099

Closed srtaalej closed 2 weeks ago

srtaalej commented 2 weeks ago

I ran $ ./scripts/install_all_and_run_tests.sh (as per the maintainers guide) and received:

ninja: Entering directory `.pytype'
[101/192] check slack_bolt.middleware.async_custom_middleware
FAILED: /Users/maria.mercado/bolt-python/.pytype/pyi/slack_bolt/middleware/async_custom_middleware.pyi 
/Users/maria.mercado/bolt-python/env_3.8.5/bin/python3 -m pytype.main --imports_info /Users/maria.mercado/bolt-python/.pytype/imports/slack_bolt.middleware.async_custom_middleware.imports --module-name slack_bolt.middleware.async_custom_middleware --platform darwin -V 3.9 -o /Users/maria.mercado/bolt-python/.pytype/pyi/slack_bolt/middleware/async_custom_middleware.pyi --analyze-annotated --nofail --quick /Users/maria.mercado/bolt-python/slack_bolt/middleware/async_custom_middleware.py
File "/Users/maria.mercado/bolt-python/slack_bolt/middleware/async_custom_middleware.py", line 45, in async_process: Function <callable> expects 1 arg(s), got 0 [wrong-arg-count]
         Expected: (_)
  Actually passed: ()

For more details, see https://google.github.io/pytype/errors.html#wrong-arg-count
ninja: build stopped: subcommand failed.
Leaving directory '.pytype'

i made changes to several README and .md files (working on issue #777) but @zimeg also ran the test script and got the same error

seratch commented 2 weeks ago

Hi @srtaalej, thanks for reporting this! I will check this out later. When you're only working on the docs, you don't need to run Python tests at all. So, you can ignore this for now 👋

seratch commented 2 weeks ago

By the way, can you share a bit more details on the steps? We have an issue template for bug reports: https://github.com/slackapi/bolt-python/blob/main/.github/ISSUE_TEMPLATE/04_bug.md

seratch commented 2 weeks ago

bolt-python/env_3.8.5

Ah, you're using Python 3.8.5. Perhaps, this would be enough for this report