Closed WilliamBergamin closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 91.80%. Comparing base (
7b19d3d
) to head (c323fdc
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR is a follow up to #1017, it aim to speed up unit test execution
Many unit tests use
asyncio.sleep
before asserting that a request tomock_web_api_server
was successfully processed. These changes allow unit tests tocontinue
as soon as requests tomock_web_api_server
are processed, instead of waiting an arbitrary amount of time.This reuses the same logic introduced by #1017 and applies it to the
async
area of the unit tests.Original
Before this PR
After
Take away
In GitHub actions using
python 3.11
, this PR allows the unit tests to run in2m18s
this is a38%
improvement compared to3m45s
previously and a54%
improvement compare to executions pre #1017On my local machine using python 3.11, this PR allows the unit tests to run in
1m35s
this is a43%
improvement compared to2m49s
previouslyCategory (place an
x
in each of the[ ]
)slack_bolt.App
and/or its core componentsslack_bolt.async_app.AsyncApp
and/or its core componentsslack_bolt.adapter
/docs
Requirements (place an
x
in each[ ]
)Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.sh
after making the changes.