Closed filmaj closed 1 year ago
Merging #69 (7a5fdef) into main (2e61dc0) will decrease coverage by
0.85%
. The diff coverage is98.96%
.
@@ Coverage Diff @@
## main #69 +/- ##
===========================================
- Coverage 100.00% 99.15% -0.85%
===========================================
Files 6 35 +29
Lines 141 1060 +919
Branches 9 10 +1
===========================================
+ Hits 141 1051 +910
- Misses 0 9 +9
Impacted Files | Coverage Δ | |
---|---|---|
...d-method-types/workflows/triggers/shortcut-data.ts | 95.74% <95.74%> (ø) |
|
...types/workflows/triggers/event-data/dnd_updated.ts | 96.00% <96.00%> (ø) |
|
...event-data/common-objects/shared_channel_invite.ts | 96.10% <96.10%> (ø) |
|
...ggers/event-data/shared_channel_invite_accepted.ts | 98.11% <98.11%> (ø) |
|
...ggers/event-data/shared_channel_invite_approved.ts | 98.11% <98.11%> (ø) |
|
...ggers/event-data/shared_channel_invite_declined.ts | 98.11% <98.11%> (ø) |
|
src/mod.ts | 100.00% <100.00%> (ø) |
|
...pes/workflows/triggers/event-data/app_mentioned.ts | 100.00% <100.00%> (ø) |
|
.../workflows/triggers/event-data/channel_archived.ts | 100.00% <100.00%> (ø) |
|
...s/workflows/triggers/event-data/channel_created.ts | 100.00% <100.00%> (ø) |
|
... and 20 more |
... and 3 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Alright round one of comments addressed! Take another look. A large majority of the changes is splitting event trigger data into separate files.
As for conflicts, I will resolve those just before merging so that reviewers can use GitHub's "View changes since last review" feature.
The idea in this PR is to provide some string literal types for:
Today, a typical trigger definition looks like:
After this PR gets merged and released, this could instead look like:
Follow-up tasks post-release: