Open srajiang opened 1 year ago
Merging #189 (8eda211) into main (abd4e33) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## main #189 +/- ##
=======================================
Coverage 99.23% 99.23%
=======================================
Files 55 55
Lines 2084 2084
Branches 115 115
=======================================
Hits 2068 2068
Misses 15 15
Partials 1 1
Impacted Files | Coverage Δ | |
---|---|---|
src/manifest/mod.ts | 100.00% <100.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Summary
Adds the
userScopes
property to the ISlackManifestShared interface. Ask from BE folks to enable authoring app manifest that use built-ins with user-delegated auth.Context thread
Changes:
userScopes
property to theISlackManifestShared
interface and sets the value on Manifest if not emptytoken_management_enabled
defaulted to false on behalf of the developer. But in the case where user scopes are requested, the backend requirestoken_management_enabled
to be set totrue
. So I have modified the SDK behavior to default to setting the value to true only when there's at least one user scope defined.Requirements (place an
x
in each[ ]
)