slackapi / deno-slack-sdk

SDK for building Run on Slack apps using Deno
https://api.slack.com/automation
MIT License
165 stars 27 forks source link

Adding pkce support field #203

Closed uhunnyslack closed 1 year ago

uhunnyslack commented 1 year ago

Summary

To support more connectors, 3p auth manifest config requires some more new SDK fields

This PR is to add a new field that helps the connector team unblock creating some more connectors.

use_pkce : boolean -> this is true for providers that uses PKCE:

More discussions can be found in our slack instance.

Important

Please do not merge it until the web app changes are merged! Thanks!

Requirements (place an x in each [ ])

codecov[bot] commented 1 year ago

Codecov Report

Merging #203 (32e7e97) into main (f7b4a35) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #203   +/-   ##
=======================================
  Coverage   99.24%   99.24%           
=======================================
  Files          56       56           
  Lines        2128     2128           
  Branches      136      136           
=======================================
  Hits         2112     2112           
  Misses         15       15           
  Partials        1        1           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

filmaj commented 1 year ago

@uhunnyslack I've assigned this PR to you and added the do not merge label to it. Feel free to merge whenever you are ready.