Closed WilliamBergamin closed 1 year ago
Merging #211 (4ad391f) into main (384252c) will increase coverage by
0.00%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #211 +/- ##
=======================================
Coverage 99.24% 99.24%
=======================================
Files 56 56
Lines 2125 2128 +3
Branches 136 136
=======================================
+ Hits 2109 2112 +3
Misses 15 15
Partials 1 1
Files Changed | Coverage Δ | |
---|---|---|
...functions/_scripts/src/templates/template_utils.ts | 100.00% <100.00%> (ø) |
|
src/schema/slack/functions/add_pin.ts | 100.00% <100.00%> (ø) |
|
...rc/schema/slack/functions/add_user_to_usergroup.ts | 100.00% <100.00%> (ø) |
|
src/schema/slack/functions/archive_channel.ts | 100.00% <100.00%> (ø) |
|
src/schema/slack/functions/create_channel.ts | 100.00% <100.00%> (ø) |
|
src/schema/slack/functions/create_usergroup.ts | 100.00% <100.00%> (ø) |
|
src/schema/slack/functions/delay.ts | 100.00% <100.00%> (ø) |
|
...c/schema/slack/functions/invite_user_to_channel.ts | 100.00% <100.00%> (ø) |
|
src/schema/slack/functions/mod.ts | 100.00% <100.00%> (ø) |
|
src/schema/slack/functions/open_form.ts | 100.00% <100.00%> (ø) |
|
... and 6 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
:loudspeaker: Have feedback on the report? Share it here.
Summary
In the builtin generation script there seems to be a circular import where
src/schema/slack/functions/_scripts/src/write_function_files.ts
indirectly importssrc/schema/slack/functions/mod.ts
. The issue steams fromsrc/schema/slack/functions/_scripts/generate
since it is cleaning all the files fromsrc/schema/slack/functions
before executingsrc/schema/slack/functions/_scripts/src/write_function_files.ts
which lead to the following error.This PR introduces a change to
_scripts/generate
that temporarily creates a dummyfunctions/mod.ts
file before executing_scripts/src/write_function_files.ts
testing
deno -V
)test-builtin-generation
branchsrc/schema/slack/functions/_scripts/README.md
to generate the latest builtinSpecial notes
I also updated the comment generation function to point users to the correct README.md file path
Requirements
deno task test
after making the changes.