Adding http post method config

slackapi / deno-slack-sdk

SDK for building Run on Slack apps using Deno

https://api.slack.com/automation

MIT License

158 stars 27 forks source link

Adding http post method config #217

Closed uhunnyslack closed 11 months ago

uhunnyslack commented 12 months ago

Summary

To support more connectors, 3p auth manifest config requires some more new SDK fields

This PR is to add a new field that helps the connector team unblock creating some more connectors.

 "body"?: {
    [key: string]: string;
  };
  "http_method_type"?: IdentityUrlHttpMethodTypeValues;

More discussions can be found in our slack instance.

Important

Please do not merge it until the web app changes are merged! Thanks!

Requirements (place an `x` in each `[ ]`)

[X] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
[X] I've read and agree to the Code of Conduct.

codecov[bot] commented 11 months ago

Codecov Report

Merging #217 (cb00710) into main (2c47acc) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #217   +/-   ##
=======================================
  Coverage   99.24%   99.24%           
=======================================
  Files          56       56           
  Lines        2128     2128           
  Branches      136      135    -1     
=======================================
  Hits         2112     2112           
  Misses         15       15           
  Partials        1        1

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

uhunnyslack commented 11 months ago

@WilliamBergamin I have addressed the review comments as suggested. Please review whenever possible. Thanks!