slackapi / deno-slack-sdk

SDK for building Run on Slack apps using Deno
https://api.slack.com/automation
151 stars 27 forks source link

Usergroups input addition to invite user to channel #295

Closed kkishan1 closed 3 months ago

kkishan1 commented 3 months ago

Summary

Recently, we have added a new optional input parameter to Invite user to channel built-in. The webapp changes are merged yesterday and are available to GA. FYI There is no breaking change for SDK if we GA'ed the change. Now, we want to update the SDK to include this new parameter. (PR) Ticket - PSA-3769 SDK changes for Invite user to channel

Testing

Tested this by creating a sample app and pointed it to the local sdk changes

  1. Test 1: Gave both user_ids and usergroup_ids ✅
  2. Test 2: Gave only user_ids ✅
  3. Test 3: Gave only usergroup_ids ✅
  4. Test 4: Gave only user_ids and empty array input usergroup_ids ✅
  5. Test 5: Gave only usergroup_ids and empty array input user_ids ✅
  6. Test 6: Didn't give both the optional inputs which will result in deploy time error ✅
kkishan@kkishan-ltmacgl test-invite % hermes deploy --slackdev
? Choose a deployed environment kk-team-test T013D8G3VMH A015YEEFBGA
Check /Users/kkishan/.slack/logs/slack-debug-20240320.log for full error logs

🚫 The provided manifest file does not validate against schema. Consult the additional errors field to locate specific issues (invalid_manifest)

Error Details:

1: Workflow function `sample_workflow` step `0` requires atleast one of the two optional inputs: user_ids or usergroup_ids for function slack#/functions/invite_user_to_channel. (missing_one_of_optional_inputs)
Source: /workflows/sample_workflow/steps/0

Special notes

Requirements

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.36%. Comparing base (3a9332a) to head (43f8774).

:exclamation: Current head 43f8774 differs from pull request most recent head 02cca3e. Consider uploading reports for the commit 02cca3e to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #295 +/- ## ======================================= Coverage 98.35% 98.36% ======================================= Files 63 63 Lines 2552 2564 +12 Branches 147 147 ======================================= + Hits 2510 2522 +12 Misses 42 42 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kkishan1 commented 3 months ago

@WilliamBergamin Yes, generated the files with the script. Updated the timeline on files ✅

kkishan1 commented 3 months ago

@filmaj the documentation is available on the link. But it needs to be updated a bit. Any idea how this documentation is generated?