slackapi / java-slack-sdk

Slack Developer Kit (including Bolt for Java) for any JVM language
https://slack.dev/java-slack-sdk/
MIT License
571 stars 212 forks source link

Add custom error handler support to Socket Mode adapter #1232

Closed seratch closed 10 months ago

seratch commented 10 months ago

ref: https://github.com/slack-samples/bolt-java-starter-template/issues/199

This pull request adds custom error handler support to SocketModeApp, which is a built-in Socket Mode adapter. I've checked other adapters too but I don't see the necessity to add similar to others so far.

Category (place an x in each of the [ ])

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

codecov[bot] commented 10 months ago

Codecov Report

Merging #1232 (883d69f) into main (37d738c) will decrease coverage by 0.78%. Report is 51 commits behind head on main. The diff coverage is 83.33%.

@@             Coverage Diff              @@
##               main    #1232      +/-   ##
============================================
- Coverage     74.87%   74.09%   -0.78%     
- Complexity     4074     4085      +11     
============================================
  Files           436      440       +4     
  Lines         12835    12995     +160     
  Branches       1301     1310       +9     
============================================
+ Hits           9610     9629      +19     
- Misses         2464     2598     +134     
- Partials        761      768       +7     
Files Coverage Δ
.../com/slack/api/bolt/socket_mode/SocketModeApp.java 72.82% <83.33%> (+0.67%) :arrow_up:

... and 24 files with indirect coverage changes

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!