slackapi / java-slack-sdk

Slack Developer Kit (including Bolt for Java) for any JVM language
https://slack.dev/java-slack-sdk/
MIT License
570 stars 209 forks source link

Removed some code smells #1238

Closed Rachit1606 closed 9 months ago

Rachit1606 commented 9 months ago

Hi, I am a masters student at dal and as a project I picked up your repo and refactored some code smells which occurred please check the changes and according accept or reject the pull request. you code is working its just i refactored some code.

Category (place an x in each of the [ ])

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

salesforce-cla[bot] commented 9 months ago

Thanks for the contribution! Unfortunately we can't verify the commit author(s): rachit r***@d***.ca. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce Inc. Contributor License Agreement and this Pull Request will be revalidated.

seratch commented 9 months ago

Hi @Rachit1606, thanks for sending this PR! However, moving DialogSubmissionPayload.Team etc. to the top level package can be a breaking change for existing users (please note that this SDK is used by many Slack customers for their business operations), so we are unable to accept such changes.

If you're still interested in improving this project, I'd suggest making changes that do not bring any public interface modifications such as runtime performance / memory usage improvements.

Let me close this PR for the above reason. Thanks again for your interest!