search

slackapi / java-slack-sdk

Slack Developer Kit (including Bolt for Java) for any JVM language
https://slack.dev/java-slack-sdk/
MIT License
570 stars 209 forks source link

Add remote function support #1239

Closed seratch closed 9 months ago

seratch commented 9 months ago

This pull request adds remote function support, which is still in beta, to this SDK.

References:

Category (place an x in each of the [ ])

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

codecov[bot] commented 9 months ago

Codecov Report

Attention: 59 lines in your changes are missing coverage. Please review.

Comparison is base (7942a3f) 74.18% compared to head (d51f7a8) 73.92%.

:exclamation: Current head d51f7a8 differs from pull request most recent head aa9c542. Consider uploading reports for the commit aa9c542 to get more accurate results

Files Patch % Lines
...on/GsonFunctionExecutedEventInputValueFactory.java 17.64% 27 Missing and 1 partial :warning:
...java/com/slack/api/methods/RequestFormBuilder.java 0.00% 8 Missing :warning:
bolt/src/main/java/com/slack/api/bolt/App.java 57.14% 2 Missing and 4 partials :warning:
...slack/api/methods/impl/AsyncMethodsClientImpl.java 0.00% 4 Missing :warning:
.../com/slack/api/methods/impl/MethodsClientImpl.java 0.00% 4 Missing :warning:
...k/api/bolt/request/builtin/BlockActionRequest.java 40.00% 2 Missing and 1 partial :warning:
...m/slack/api/model/event/FunctionExecutedEvent.java 25.00% 2 Missing and 1 partial :warning:
...m/slack/api/bolt/request/builtin/EventRequest.java 60.00% 0 Missing and 2 partials :warning:
.../main/java/com/slack/api/bolt/context/Context.java 83.33% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1239 +/- ## ============================================ - Coverage 74.18% 73.92% -0.27% - Complexity 4097 4109 +12 ============================================ Files 441 443 +2 Lines 13018 13106 +88 Branches 1310 1329 +19 ============================================ + Hits 9657 9688 +31 - Misses 2593 2642 +49 - Partials 768 776 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

seratch commented 9 months ago

Mistakenly i merged this PR into main branch, so did force revert (by changing the branch protection settings for the operation; then i got back the proper protection settings); i will come up with a new PR for this; sorry for the confusion here